On Sat, 2006-07-29 at 11:45 +0400, Alexey Dobriyan wrote:
> Header doesn't use anything from atomic.h.
> It fixes headers_check warning:
> 
> include/linux/netfilter_bridge.h requires asm/atomic.h, which does not exist
> 
> Compile tested on
> alpha     arm   i386-up  sparc    sparc64-up  x86_64
> alpha-up  i386           sparc64  sparc-up    x86_64-up
> 
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
> ---
> 
>  include/linux/netfilter_bridge.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/include/linux/netfilter_bridge.h
> +++ b/include/linux/netfilter_bridge.h
> @@ -6,7 +6,6 @@ #define __LINUX_BRIDGE_NETFILTER_H
>  
>  #include <linux/netfilter.h>
>  #if defined(__KERNEL__) && defined(CONFIG_BRIDGE_NETFILTER)
> -#include <asm/atomic.h>
>  #include <linux/if_ether.h>
>  #endif

Hm, that could have been dropped entirely by '#unifdef -U__KERNEL__'.
P'raps we could teach unifdef that '#if defined(FOO) && ...' is always
false if -UFOO.

Dropping the include in this case is _also_ the right thing to do
though, since it doesn't actually need to be there even for in-kernel
compilation.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to