Hi Andrew, On Wed, Jun 14, 2017 at 06:35:37PM +0200, Andrew Lunn wrote: > On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote: > > > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > > -MV78xx0, Armada 370 and Armada XP have an identical unit that provides > > -an interface with the MDIO bus. This driver handles this MDIO > > -interface. > > +MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an > > +identical unit that provides an interface with the MDIO bus or > > +with the xMDIO bus. This driver handles these interfaces. > > This patches is looking good now. One nit. The description above > suggests Kirkwood, Dove, Orion5x, MV78xx0, Armada 370 and Armada XP > all have xmdio. Maybe better wording would be: > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > MV78xx0, Armada 370, Armada XP, Armada 7k and Armada 8k have an > identical unit that provides an interface with the MDIO bus. > Additionally, Armada 7k and Armada 8k has a second unit which > provides an interface with the xMDIO bus. This driver handles > these interfaces.
Agreed, your description is better :) I'll respin this patch only, if there is no other comment. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
