On Mon, Jun 19, 2017 at 11:37 PM, jeffy <jeffy.c...@rock-chips.com> wrote: > Hi Cong Wang, > > > On 06/20/2017 12:54 PM, Cong Wang wrote: >> >> Interesting, I didn't notice this corner-case, because normally >> we would hit the one in rollback_registered_many(). Probably >> we need to add a check >> >> if (dev->reg_state == NETREG_UNREGISTERING) >> >> in ip6_route_dev_notify(). Can you give it a try? > > the NETREG_UNREGISTERING check works for my test:) > > but i saw dev_change_net_namespace also call NETDEV_UNREGISTER & > NETDEV_REGISTER:
Yes we should call it in this case too, only netdev_wait_allrefs() is an exceptional case here. I just sent out a formal patch with you Cc'ed. Thanks!