On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: > On Mon, Jun 26, 2017 at 6:35 PM, <gfree.w...@vip.163.com> wrote: > > From: Gao Feng <gfree.w...@vip.163.com> > > > > When qdisc fail to init, qdisc_create would invoke the destroy callback > > to cleanup. But there is no check if the callback exists really. So it > > would cause the panic if there is no real destroy callback like these > > qdisc codel, pfifo, pfifo_fast, and so on. > > > > Now add one the check for destroy to avoid the possible panic. > > > > Signed-off-by: Gao Feng <gfree.w...@vip.163.com> > > Looks good, > > Acked-by: Cong Wang <xiyou.wangc...@gmail.com> > > This is introduced by commit 87b60cfacf9f17cf71933c6e33b. > Please add proper Fixes tag next time.
Given that pfifo, pfifo_fast or codel can not fail their init, I do not see this patch as a net candidate, and the Fixes: tag seems not needed. Gao, have you really hit a bug, or is this patch some kind of cleanup or prep work ? If yes, please properly identify which packet scheduler had an issue. Thanks.
