On Mon, Jul 10, 2017 at 01:29:20PM +0300, Dan Carpenter wrote: > The "goto no_pps" was a bug you introduced.
I took a second look, and yes, the original commit should not have returned NULL, and the original callers did not expect NULL either. > But I feel like you're being rude, so I'm not going to resend these > patches. Please fix them yourself. Sorry you feel that way. Your first patch, although now more or less cosmetic, would be okay. The second patch is still wrong. Thanks, Richard
