From: John Fastabend <john.fastab...@gmail.com> Date: Thu, 13 Jul 2017 10:00:15 -0700
> On 07/13/2017 09:16 AM, Jesper Dangaard Brouer wrote: >> On Thu, 13 Jul 2017 13:14:30 +0200 >> Jesper Dangaard Brouer <bro...@redhat.com> wrote: >> >>> I'm still getting crashes (but much harder to provoke), but I figured >>> out why. We sort of missed one case, where map_to_flush gets set, when >>> the ndo_xdp_xmit() call starts to fail, and the ixgbe driver then >>> forgets to call xdp_do_flush_map, if all packets in that NAPI cycle >>> failed. We could blame the driver, but yhe clean solution is making >>> sure, that we don't set map_to_flush when the __bpf_tx_xdp() call >>> fails. It should also handle the other case I fixed .... I'll cleanup >>> my PoC-fix patch, test it and provide it here. >> >> I changed flow in the function to be: > > > Great, I'll merge this, the other couple fixes, and the bitops optimization > and > hopefully then we are set. I'll post a v2 and we can do some final checks. I am so looking forward to merging this, great work everyone.
