On Wed, 2017-07-19 at 17:19 +0800, Aviad Krawczyk wrote:
> Add ethtool operations and statistics operations.
series trivia:
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c
> b/drivers/net/ethernet/huawei/hinic/hinic_main.c
[]
> @@ -67,6 +67,178 @@
[]
> +static int hinic_get_link_ksettings(struct net_device *netdev,
> + struct ethtool_link_ksettings
> + *link_ksettings)
> +{
[]
> + err = hinic_port_get_cap(nic_dev, &port_cap);
> + if (err) {
> + dev_err(&netdev->dev, "Failed to get port capabilities\n");
> + return err;
> + }
it looks like a lot of these dev_<level> calls
should be converted to netdev_<level>
from:
dev_err(&netdev->dev, ...);
to:
netdev_err(netdev, ...);
etc...
