Hi! On Thu 2017-07-06 15:00:37, Cong Wang wrote: > This fixes the following kernel warning: > > [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 > [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: <none>/-1, > .owner_cpu: 0 ... > by adding the missing spin_lock_init(). > > Reported-by: Pavel Machek <pa...@ucw.cz> > Cc: Kalle Valo <kv...@codeaurora.org> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Ping? This is pretty trivial bugfix for an ugly problem. It would be nice to take it in. > drivers/net/wireless/ti/wl1251/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ti/wl1251/main.c > b/drivers/net/wireless/ti/wl1251/main.c > index bbf7604..1c539c8 100644 > --- a/drivers/net/wireless/ti/wl1251/main.c > +++ b/drivers/net/wireless/ti/wl1251/main.c > @@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void) > > wl->state = WL1251_STATE_OFF; > mutex_init(&wl->mutex); > + spin_lock_init(&wl->wl_lock); > > wl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE; > wl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
