On 29/07/2017 13:24, Måns Rullgård wrote: > Until you figure out why it's getting stuck, we can't be sure > it isn't caused by something that could trigger at any time. Would you take a look at it, if I can reproduce on tango4?
I have identified a 100% reproducible flaw. I have proposed a work-around that brings this down to 0 (tested 1000 cycles of link up / ping / link down). In my opinion, upstream should consider this work-around for inclusion. I'd like to hear David's and Florian's opinion on the topic. It's always a pain to maintain out-of-tree patches. > Yes, but by then you've reset those parameters to the defaults. Good catch. There is some non HW-related init in nb8800_hw_init(). I'll take this opportunity to change flow control to off by default (it breaks several 100 Mbps switches). I'll take a closer look at priv assignments on Monday. Regards.
