On Fri, 28 Jul 2017 21:59:19 +0200
Natale Patriciello <[email protected]> wrote:
> +
> +#define WAVE_DEBUG 1
> +
> +#ifdef WAVE_DEBUG
> + #define DBG(msg ...) printk(KERN_DEBUG "WAVE_DEBUG: " msg)
> +#else
> + static inline void DBG(const char *msg, ...) { }
> +#endif
> +
Don't reinvent your own debug macros.
Use standard pr_debug instead.
+
+ if (ca->history != 0)
+ kfree(ca->history);
First, off the comparison should be with NULL not 0.
Secondly, kfree already does the right thing with kfree(NULL).
+ /* Usually the burst end is also reflected in the rs->delivered
+ * variable. If this is not the case, and such variable is
+ * behind just for 1 segment, then do this experimental thing
+ * to re-allineate the burst with the rs->delivered variable.
+ * In the majority of cases, we went out of allineation because
+ * of a tail loss probe. */
Put the last */ in column with other parts of block.
* of a tail loss probe.
*/
