From: Hannes Frederic Sowa <han...@stressinduktion.org>
Date: Fri, 28 Jul 2017 16:47:42 -0400

> David Miller <da...@davemloft.net> writes:
> 
>> The red flag is that we are indexing 'start' with 'doffset' instead of
>> 'soffset'.
> 
> As Paolo pointed out, we should not put our own source address into the
> options array.
> 
> Do you have any idea why this code was added in the first place? I read
> through 2.0.33 code and even in context of this version, I couldn't
> figure that out.
> 
> Because it seems the code and update is dead anyways (besides
> incorrectly updating the ICMP reflected payload) I don't see any problem
> with removing this code. Do you?

Ok, now I'm convinced it's dead code.

Thanks for explaining.

Reply via email to