On Sun, 2017-08-06 at 21:57 +0400, Ilya Matveychikov wrote:
> > On Aug 6, 2017, at 9:07 PM, Eric Dumazet <eric.duma...@gmail.com> wrote:
> > On Sun, 2017-08-06 at 13:51 +0400, Ilya Matveychikov wrote:
> >> As tcp_data_queue() function is used just only twice it's better
> >> to move out the first check and wrap it with inline. It saves a
> >> single call in case the condition evaluated as true.
> > We wont accept such a change, because this code does not need to be
> > inlined in the callers, ( and btw inline in .c files are discouraged
> > these days )
> Not sure that I understand you point. What’s the reason for that code
> not need to be inlined in the callers?
You sent a patch, you have to explain why it is needed.
Your changelog is absolutely not giving a compelling reason.
TCP stack is already complex, no need to add yet another obfuscation
unless there is a strong reason.