On 8/9/17 10:41 PM, David Miller wrote:
From: Girish Moodalbail <girish.moodalb...@oracle.com>
Date: Tue,  8 Aug 2017 17:26:24 -0700

Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range
of values for it would be from 0 to 16777215 (2^24 -1).  However, one
cannot create a geneve device with VNI set to 16777215. This patch fixes
this issue.

Signed-off-by: Girish Moodalbail <girish.moodalb...@oracle.com>

I always worry that someone, somewhere, might be using this in some
way and this will break things.

But I'll apply this for now.

Thanks David. As per the output of 'ip link help geneve', 16777215 is a valid value. However, due to incorrect check in the kernel that value was not supported.

$ ip link help geneve |egrep -A1 VNI
Usage: ... geneve id VNI
                  remote ADDR
Where: VNI   := 0-16777215
       ADDR  := IP_ADDRESS

So, this is an off-by-one bug and no one had tripped over it until now.


Reply via email to