On 8/11/17 10:39 AM, Jiri Benc wrote:
>>> +       if (!data) {
>>> +               NL_SET_ERR_MSG(extack,
>>> +                              "Not enough attributes provided to perform 
>>> the operation");
>>>                 return -EINVAL;
>>> +       }
>> "not enough attributes"
> You're missing part of the sentence.

I would argue none of those messages are sufficient. The message should
tell the user what is missing.

What is the point of the !data check anyway? Based on the rest of the
validate function neither IFLA_VXLAN_ID or IFLA_VXLAN_PORT_RANGE are
required attributes.

Reply via email to