On Tue, 8 Aug 2017 16:15:41 +0300, Arkadi Sharshevsky wrote:
> Driver <--> Devlink API
> =======================
> Each driver will register his resources with default values at init in
> a similar way to DPIPE table registration. In case those resources already
> exist the default values are discarded. The user will be able to dump and
> update the resources. In order for the changes to take place the user will
> need to re-initiate the driver by a specific devlink knob.

What seems missing from the examples is the ability to dump the
different states - the "pending" configuration and the currently
applied one.

> The above described procedure will require extra reload of the driver.
> This can be improved as a future optimization.

I'm a bit lost, this says driver reload is required...

> ====
> The user will be able to update the resources on a per resource basis:
> $devlink dpipe resource set pci/0000:03:00.0 Mem_Linear 2M
> For some resources the size is fixed, for example the size of the internal
> memory cannot be changed. It is provided merely in order to reflect the
> nested structure of the resource and to imply the user that Mem = Linear +
> Hash, thus a set operation on it will fail.
> The user can dump the current resource configuration:
> #devlink dpipe resource dump tree pci/0000:03:00.0 Mem
> The user can specify 'tree' in order to show all the nested resources under
> the specified one. In case no 'resource name' is specified the TOP hierarchy
> will be dumped.
> After successful resource update the drivers hould be re-instantiated in
> order for the changes to take place:
> $devlink reload pci/0000:03:00.0

... but this shows a devlink reload tigger, so no driver reload?  Were
you describing two possible solutions?  One with persistent kernel
database of configs (persistent across driver reloads) and one with no
persistence and the driver is managing reinit internally when triggered
via devlink?

Another thing that comes to mind is - in case HW/FW reinit takes long
would it make sense to incorporate some form of pre-population of those
defaults somehow?  If user knows exactly the config they want upon
boot, it would seem cleaner if the reconfig did not have to happen and
devices started out in the right mode.

Reply via email to