On 2017年08月17日 00:55, Michael S. Tsirkin wrote:
On Wed, Aug 16, 2017 at 10:14:33PM +0800, Jason Wang wrote:
From: Eric Dumazet<eric.duma...@gmail.com>

tun_build_skb() is not thread safe since it uses per queue page frag,
this will break things when multiple threads are sending through same
queue. Switch to use per-thread generator (no lock involved).

Fixes: 66ccbc9c87c2 ("tap: use build_skb() for small packet")
Tested-by: Jason Wang<jasow...@redhat.com>
Signed-off-by: Eric Dumazet<eric.duma...@gmail.com>
Signed-off-by: Jason Wang<jasow...@redhat.com>
Acked-by: Michael S. Tsirkin<m...@redhat.com>

Jason, given the switch to task_frag, would it be worth it to look at
using higher order allocs along the lines of
5640f7685831e088fe6c2e1f863a6805962f8e81 as well?


I think we've already used high order, don't we?

Thanks

Reply via email to