On 08/17/2017 11:40 AM, Florian Westphal wrote: > Andrew Lunn <and...@lunn.ch> wrote: >> On Thu, Aug 17, 2017 at 04:47:00PM +0200, Florian Westphal wrote: >>> compile tested only, but saw no warnings/errors with >>> allmodconfig build. >>> >>> static int dsa_switch_rcv(struct sk_buff *skb, struct net_device *dev, >>> - struct packet_type *pt, struct net_device *orig_dev) >>> + struct packet_type *pt, struct net_device *unused) >> >> Hi Florian >> >> Looks O.K. to me. I can test it out later. >> >> Is there a bigger picture here? Do you plan to remove the second >> net_device parameter everywhere? > > Its tempting, seems only af_packet uses it. I'll see if there is > another (simpler) way of getting the orig ifindex into af_packet. >
FWIW, I still have some changes queued locally that make use of orig_dev to support the switch tag HW insertion/extraction, but I think "dev" here is equally suitable since it still points to the DSA master network device. -- Florian
