From: Thomas Graf <[EMAIL PROTECTED]>
Date: Wed, 9 Aug 2006 00:16:51 +0200

> * Ville Nuorvala <[EMAIL PROTECTED]> 2006-08-09 01:05
> >     [IPV6]: Make sure fib6_rule_lookup doesn't return NULL
> >     
> >     The callers of fib6_rule_lookup don't expect it to return NULL,
> >     therefore it must return ip6_null_entry whenever fib_rule_lookup fails.
> >     
> >     Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]>
> 
> I think it would be a lot cleaner to return an error code
> like fib_lookup() and save the atomic operations. We only
> destroy the dst again anyway in case of a failure.

Yes, the current scheme is a poor substitute for IS_ERR/PTR_ERR.

But for now let's fix the bug and apply Ville's patch.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to