+       priv = netdev_priv(rmnet_dev);
+       memset(priv, 0, sizeof(struct rmnet_priv));

Netdev private area is always zero on creation. See alloc_netdev().

+       if (!rmnet_dev)
+               return 0;

Do not confuse 0 with NULL. Did you run sparse?

+
+       priv = netdev_priv(rmnet_dev);
+       if (!priv)
+               return 0;


netdev_priv() always returns a non-NULL value. The private area is just
a constant offset below the original network_device structure.

Hi Stephen

I havent used sparse till now. I'll fix the errors reported by it as well
your other comments and post again.


--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Reply via email to