On Mon, Aug 28, 2017 at 07:10:04AM -0700, John Fastabend wrote: > In the initial sockmap API we provided strparser and verdict programs > using a single attach command by extending the attach API with a the > attach_bpf_fd2 field. > > However, if we add other programs in the future we will be adding a > field for every new possible type, attach_bpf_fd(3,4,..). This > seems a bit clumsy for an API. So lets push the programs using two > new type fields. > > BPF_SK_SKB_STREAM_PARSER > BPF_SK_SKB_STREAM_VERDICT > > This has the advantage of having a readable name and can easily be > extended in the future. > > Updates to samples and sockmap included here also generalize tests > slightly to support upcoming patch for multiple map support. > > Signed-off-by: John Fastabend <john.fastab...@gmail.com> > Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") > Suggested-by: Alexei Starovoitov <a...@kernel.org>
lgtm Acked-by: Alexei Starovoitov <a...@kernel.org>