> -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, September 07, 2017 2:25 PM > To: Tristram Ha - C24268 > Cc: muva...@gmail.com; pa...@ucw.cz; nathan.leigh.con...@gmail.com; > vivien.dide...@savoirfairelinux.com; f.faine...@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Woojung Huh - C21699 > Subject: Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ > switch drivers. > > On Thu, Sep 07, 2017 at 09:08:58PM +0000, tristram...@microchip.com wrote: > > From: Tristram Ha <tristram...@microchip.com> > > > > Break ksz_common.c into 2 files so that the common code can be used by other > KSZ switch drivers. > > > > Signed-off-by: Tristram Ha <tristram...@microchip.com> > > --- > > diff --git a/drivers/net/dsa/microchip/Makefile > > b/drivers/net/dsa/microchip/Makefile > > index ed335e2..0961c30 100644 > > --- a/drivers/net/dsa/microchip/Makefile > > +++ b/drivers/net/dsa/microchip/Makefile > > @@ -1,2 +1,2 @@ > > -obj-$(CONFIG_MICROCHIP_KSZ) += ksz_common.o > > +obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o > > Hi Tristram > > I would of thought this would break the build. You don't add ksz9477.c until > the > next patch. > > Each patch needs to compile, otherwise you break git bisect. > > Andrew
Eventually the file will need to be broken in two, so you would like to see all 3 changes (Makefile, ksz_common.c, and ksz9477.c) in 1 patch file?
