On Fri, Aug 11, 2006 at 06:49:43PM -0700, Andrew Morton wrote:
> On Sat, 12 Aug 2006 04:46:23 +0400
> Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
>
> > +#ifdef CONFIG_PM
> > static int amd8111e_suspend(struct pci_dev *pci_dev, pm_message_t state)
> > {
> > struct net_device *dev = pci_get_drvdata(pci_dev);
> > @@ -1873,7 +1879,7 @@ static int amd8111e_resume(struct pci_de
> >
> > return 0;
> > }
> > -
> > +#endif
> >
> > static void __devexit amd8111e_remove_one(struct pci_dev *pdev)
> > {
> > @@ -2152,8 +2158,10 @@ static struct pci_driver amd8111e_driver
> > .id_table = amd8111e_pci_tbl,
> > .probe = amd8111e_probe_one,
> > .remove = __devexit_p(amd8111e_remove_one),
> > +#ifdef CONFIG_PM
> > .suspend = amd8111e_suspend,
> > .resume = amd8111e_resume
> > +#endif
> > };
>
> The preferred way is
>
> #ifdef CONFIG_PM
> static int amd8111e_suspend(...)
> {
> }
> #else
> #define amd8111e_suspend NULL
> #define amd8111e_resume NULL
> #endif
Plenty of drivers already use first variant. Also this won't allow
struct pci_driver {
...
#ifdef CONFIG_PM
int (*suspend)(...);
int (*resume)(...);
#endif
...
};
which is good for a) space savings in CONFIG_PM=n case, and
b) making drivers care about CONFIG_PM=n users hard way aka compilation
failure.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
