Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53

[Vivien Didelot]

Hi Florian,

Florian Fainelli <f.faine...@gmail.com> writes:

> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, 
> int port,
>       core_writel(priv, reg, offset);
>  
>       if (!phydev->is_pseudo_fixed_link)
> -             p->eee_enabled = bcm_sf2_eee_init(ds, port, phydev);
> +             p->eee_enabled = b53_eee_init(ds, port, phydev);
>  }

I know this is a bit out-of-scope of this patch, but I have to say I am
not confortable with having still phy device stuffs in switch drivers...

Can this is_pseudo_fixed_link check + phy_eee_init + eee_enable be moved
up to dsa_slave_adjust_link in a future patch maybe?

Thanks,

        Vivien