Hi Mark, > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -1,6 +1,6 @@ > > -#!/bin/sh > > +#!/bin/bash
> Funny - ^^^ choosing bash explicitly while > vvvv removing the bashism? Eh, this is really silly, sorry. I've sent a patch to revert it back as it was unintentional. > I noticed a couple other files already specified /bin/bash, yet you removed > the bashisms. But the above struck me as something that would not seem to > have been intended. I plan to remove all bashisms. Although having explicit dependency on bash (i.e. /bin/bash in shebang), it would be nice have posix compliant shell scripts (as Randy Dunlap also noted). Or at least don't have bashisms in script with /bin/sh shebang. Kind regards, Petr