Hi David,
David Laight <david.lai...@aculab.com> writes:
[...]
>> > index 099bf5528fed..41e349df4bf4 100644
>> > --- a/include/uapi/linux/pkt_sched.h
>> > +++ b/include/uapi/linux/pkt_sched.h
>> > @@ -871,4 +871,22 @@ struct tc_pie_xstats {
>> > __u32 maxq; /* maximum queue size */
>> > __u32 ecn_mark; /* packets marked with ecn*/
>> > };
>> > +
>> > +/* CBS */
>> > +struct tc_cbs_qopt {
>> > + __u8 offload;
>
> You probably don't want unnamed padding in a uapi structure.
Yeah, this needs to be fixed.
>
>> > + __s32 hicredit;
>> > + __s32 locredit;
>> > + __s32 idleslope;
>> > + __s32 sendslope;
>> > +};
>> > +
>> > +enum {
>> > + TCA_CBS_UNSPEC,
>> > + TCA_CBS_PARMS,
>> > + __TCA_CBS_MAX,
>> > +};
>> > +
>> > +#define TCA_CBS_MAX (__TCA_CBS_MAX - 1)
>
> Why not:
> TCA_CBS_PARMS,
> TCA_CBS_NEXT,
> TCA_CBS_MAX = TCA_CBS_NEXT - 1,
The way it is proposed, at least is consistent with the rest of the
file. So, if you don't have any stronger reasons, I'd like to keep it
this way.
>
> ...
> David
Cheers,
--
Vinicius
