On Fri, 2017-07-28 at 16:22 -0700, Tom Herbert wrote:
> Generalize strparser from more than just being used in conjunction
> with read_sock. strparser will also be used in the send path with
> zero proxy. The primary change is to create strp_process function
> that performs the critical processing on skbs. The documentation
> is also updated to reflect the new uses.
>
> Signed-off-by: Tom Herbert <t...@quantonium.net>
> ---
> Documentation/networking/strparser.txt | 207 +++++++++++++++-------
> include/net/strparser.h | 119 +++++++------
> net/kcm/kcmproc.c | 34 ++--
> net/kcm/kcmsock.c | 38 ++--
> net/strparser/strparser.c | 313
> ++++++++++++++++++++-------------
> 5 files changed, 424 insertions(+), 287 deletions(-)
Just found this gem :
static void strp_msg_timeout(unsigned long arg)
{
struct strparser *strp = (struct strparser *)arg;
/* Message assembly timed out */
STRP_STATS_INCR(strp->stats.msg_timeouts);
strp->cb.lock(strp);
strp->cb.abort_parser(strp, ETIMEDOUT);
strp->cb.unlock(strp);
}
static void strp_sock_lock(struct strparser *strp)
{
lock_sock(strp->sk);
}
static void strp_sock_unlock(struct strparser *strp)
{
release_sock(strp->sk);
}
A timer runs from BH, and from this interrupt context it is absolutely
illegal to call lock_sock() ( and release_sock() )
Please fix, thanks !
