Hi everyone,
Apologies for the resend, but wanted to add the acks by Jamal and Jiri for this
review contingent upon the changes that are made herein. Had forgotten to add
them the first time around.
I've made all requested changes to the act_vlan TC action, tested them, and
here's the new changeset. Could you please review and let me know
if I can commit this? Thanks a lot!
Here're the fixes:
*> Fixed all helper functions to use RCU (rtnl_dereference).
*> Fixed indentation, extra line nits
*> Moved rcu_head to the end of the struct
*> Converted to reverse-christmas-tree
*> Removed mismatched spin_lock()
*> Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should suffice.
Thanks for all the comments!
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
Acked-by: Jiri Pirko <j...@mellanox.com>
Signed-off-by: Manish Kurup <manish.ku...@verizon.com>
Manish Kurup (2):
net sched act_vlan: Change stats update to use per-core stats
net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and
update
include/net/tc_act/tc_vlan.h | 46 ++++++++++++++++++++++------
net/sched/act_vlan.c | 71 ++++++++++++++++++++++++++++----------------
2 files changed, 82 insertions(+), 35 deletions(-)
--
2.7.4
