> -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Monday, October 30, 2017 2:20 PM > To: [email protected] > Cc: [email protected]; Nogah Frankel <[email protected]>; > [email protected]; > [email protected]; mlxsw <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; > [email protected]; Saeed Mahameed <[email protected]>; Matan Barak > <[email protected]>; Leon Romanovsky <[email protected]>; Ido Schimmel > <[email protected]>; [email protected]; > [email protected]; > [email protected]; [email protected]; > [email protected]; Or Gerlitz <[email protected]>; > [email protected] > Subject: Re: [patch net-next RFC 1/9] net_sch: red: Add offload ability to > RED qdisc > > From: Jiri Pirko <[email protected]> > Date: Mon, 30 Oct 2017 09:56:05 +0100 > > > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > > index 0e88cc2..743c42a 100644 > > --- a/include/uapi/linux/pkt_sched.h > > +++ b/include/uapi/linux/pkt_sched.h > > @@ -255,6 +255,7 @@ struct tc_red_qopt { > > #define TC_RED_ECN 1 > > #define TC_RED_HARDDROP 2 > > #define TC_RED_ADAPTATIVE 4 > > +#define TC_RED_OFFLOADED 8 > > }; > > > > struct tc_red_xstats { > > What keeps a user from setting this flag in the tc_red_qopt it > passes into the a change operation?
Nothing keeps the user from doing it, but it has no effect. The decision to offload is the driver's only. It is basically a read-only flag.
