On Mon, Oct 30, 2017 at 7:12 PM, David Laight <david.lai...@aculab.com> wrote: > From: Xin Long >> Sent: 28 October 2017 12:44 >> These warnings were found by running 'make C=2 M=net/sctp/'. >> They are there since very beginning. > ... >> - param.crr_id = i; >> + param.crr_id = htonl(i); > ... > > Isn't this a bug fix, not just removing a warning?? It's actually fiine, crr_id is just an identifier, and receiver will only pack the same value to the asconf_ack chunk, and then sender checks with: if (asconf_ack_param->crr_id == asconf_param->crr_id) ...
So no issue could be caused by this, I didn't count it as a bug.
