Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

[David Miller]

From: Michael Grzeschik <m.grzesc...@pengutronix.de>
Date: Mon,  6 Nov 2017 12:10:04 +0100

> We add the call of_phy_deregister_fixed_link to all associated
> error paths for memory clean up.
> 
> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de>
> ---
>  drivers/net/ethernet/cadence/macb_main.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c 
> b/drivers/net/ethernet/cadence/macb_main.c
> index 6df2cad61647a..2c2acd011329a 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -611,6 +611,8 @@ static int macb_mii_init(struct macb *bp)
>  err_out_unregister_bus:
>       mdiobus_unregister(bp->mii_bus);
>  err_out_free_mdiobus:
> +     if ((np) && (of_phy_is_fixed_link(np)))

Please don't use so many parenthesis in your conditionals:

        if (np && of_phy_is_fixed_link(np))

is more than sufficient.

Please fix this in your entire set of patches.

Thank you.