❦ 11 novembre 2017 19:58 +0800, Xin Long <lucien....@gmail.com> :
> Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport
> header offset") removed icmp6_code and icmp6_type check before calling
> neigh_reduce when doing neigh proxy.
>
> It means all icmpv6 packets would be blocked by this, not only ns packet.
> In Jianlin's env, even ping6 couldn't work through it.
>
> This patch is to bring the icmp6_code and icmp6_type check back and also
> removed the same check from neigh_reduce().
I am very sorry for not having spotted this bug earlier. I have tested
your fix and I can confirm it works as expected.
> Fixes: f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport
> header offset")
> Reported-by: Jianlin Shi <ji...@redhat.com>
> Signed-off-by: Xin Long <lucien....@gmail.com>
Reviewed-by: Vincent Bernat <vinc...@bernat.im>
--
Don't just echo the code with comments - make every comment count.
- The Elements of Programming Style (Kernighan & Plauger)
