Mon, Nov 13, 2017 at 08:17:34AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicin...@netronome.com wrote: >> >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko <j...@mellanox.com> >> >> >> >> In order to remove tp->q usage in cls_bpf, the offload->netdev check >> >> needs to be moved to individual drivers as only they will have access >> >> to appropriate struct net_device. >> >> >> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> >> > >> >This seems not entirely correct and it adds unnecessary code. I think >> >> What is not correct? > >From quick reading it looks like you will allow to install the >dev-specific filter without skip_sw flag. You haven't fixed what
Right. I see it now. >your previous series broke in cls_bpf offload model and now you What do you mean exactly? >break it even further. > >> >the XDP and cls_bpf handling could be unified, making way for binding >> >the same program to multiple ports of the same device. Would you mind >> >waiting a day for me to send corrections to BPF offload? >> >> Well I'm trying to get this in before net-next closes... > >Right, and I'm surprised by that. I'd hope you'll understand my caution >here given recent history. Sure.
