On Mon, 27 Nov 2017 19:00:14 +0100
Michal Privoznik <[email protected]> wrote:
> parse_action_control helper does advancing of the arg inside. So don't
> do it outside.
>
> Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control
> actions")
> Signed-off-by: Michal Privoznik <[email protected]>
The helpers are not helping here.
Adding another layer of indirection on moving argc/argv then causing caller
to have to keep track is bad design.
Also since pars_action_control_slash is only used by police, why was it
moved into tc_util in the first place? I would prefer just to rip out that
bit and put it back in policer.
