On Tue, 22 Aug 2006 16:15:47 -0500, Larry Finger wrote:
> No it cannot change between frames; however, the max value can be very 
> different for different 
> drivers using d80211. On the bcm43xx, it is 60; whereas 100 seems to be a 
> better value for the 
> rt2x00 chips. Adding it here seemed like a good way to handle this situation. 
> Do you suggest 
> something else?

As Johannes already said, it should be in ieee80211_hw. 

> >> [...]
> >> --- a/net/d80211/ieee80211_i.h
> >> +++ b/net/d80211/ieee80211_i.h
> >> @@ -337,6 +337,9 @@ struct ieee80211_local {
> >>    struct net_device *apdev; /* wlan#ap - management frames (hostapd) */
> >>    int open_count;
> >>    int monitors;
> >> +  int link_quality;
> >> +  int noise;
> >> +  struct iw_statistics wstats;
> > 
> > Why are these three variables in ieee80211_local? They are not used
> > anywhere.
> 
> You are right about the first two; however, wstats is used in the new
> routine ieee80211_get_wireless_stats.

Oh, get_wireless_stats returns struct iw_statistics, so it needs to be
allocated all the time. Grr, that's stupid...

Okay, wstats really needs to be in ieee80211_local then.

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to