On Tue, Dec 19, 2017 at 08:20:44PM +0200, Andy Shevchenko wrote:
> Replace sscanf() with mac_pton().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>

Nice cleanup.  Thanks!

Acked-by: Andy Gospodarek <a...@greyhouse.net>

> ---
>  drivers/net/bonding/bond_options.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_options.c 
> b/drivers/net/bonding/bond_options.c
> index 8a9b085c2a98..58c705f24f96 100644
> --- a/drivers/net/bonding/bond_options.c
> +++ b/drivers/net/bonding/bond_options.c
> @@ -1431,13 +1431,9 @@ static int bond_option_ad_actor_system_set(struct 
> bonding *bond,
>  {
>       u8 macaddr[ETH_ALEN];
>       u8 *mac;
> -     int i;
>  
>       if (newval->string) {
> -             i = sscanf(newval->string, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> -                        &macaddr[0], &macaddr[1], &macaddr[2],
> -                        &macaddr[3], &macaddr[4], &macaddr[5]);
> -             if (i != ETH_ALEN)
> +             if (!mac_pton(newval->string, macaddr))
>                       goto err;
>               mac = macaddr;
>       } else {
> -- 
> 2.15.1
> 

Reply via email to