RE: [PATCH net-next 3/3] r8169: improve runtime pm in general and suspend unused ports

[Hayes Wang]

Heiner Kallweit [mailto:hkallwe...@gmail.com]
> Sent: Tuesday, January 09, 2018 4:39 AM
[...]
> - Change rtl8169_runtime_suspend to power down the chip if the
>   interface is down.

The original driver has done it. I don't think you have to do it again in 
rtl8169_runtime_suspend().

[...]
> -     if (!tp->TxDescArray)
> +     if (!tp->TxDescArray) {
> +             rtl_pll_power_down(tp);
>               return 0;
> +     }

It is unnecessary.

Best Regards,
Hayes