On 01/10/2018 01:25 PM, Quentin Monnet wrote: > Jakub says: > > Hi! > > This series starts with a fix to Jesper's recent work, somehow I forgot > about control rings during review. Second patch is cleaning up a vNIC > header, in kdoc we should not use @ for #define constants. Aligning of > the top of the stack as well as bottom (last bytes will be unused) helps > the performance. We should check offload datapath's max MTU when program > is loaded and we can allow TC hw offload flag to be changed freely while > XDP offload is active. > > Next group of patches adds more fully featured relocation support. Due > to limited amount of code space we only load the image to NIC's memory > when program is attached. Since we can't predict which programs are > loaded later, we should translate as if image was to be loaded at offset > zero and only apply relocations at load time. Many more advanced features > (eg. tail class, subprograms, dynamic allocation of program space and > sharing it between ports) will depend on this. > > Nic adds support for signed comparison instructions. > > Quentin makes use of the verifier log in our driver, the verifier print > function (verbose()) has to be renamed and exported. > > v2: > - replace #define by function aliasing for verbose() in patch 13
That's better, thanks for addressing the alias as well. Series applied to bpf-next, thanks guys!
