On Mon, 28 Aug 2006 16:36:39 +0800, Hong Liu wrote:
> "iwconfig key [x]" behavior is not correctly handled in the stack, also
> modify the giwencode method to show the key info.

Thanks for spotting and fixing these bugs!

> @@ -2869,7 +2877,8 @@ static int ieee80211_ioctl_giwencode(str
>               return 0;
>       }
>  
> -     erq->length = 0;
> +     erq->length = sdata->keys[idx]->keylen;
> +     memcpy(key, sdata->keys[idx]->key, erq->length);

Shouldn't there be a check for buffer size here?

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to