> -----Original Message----- > From: David Ahern [mailto:dsah...@gmail.com] > Sent: Tuesday, January 16, 2018 12:41 AM > To: Chris Mi <chr...@mellanox.com>; netdev@vger.kernel.org > Cc: gerlitz...@gmail.com; step...@networkplumber.org; > marcelo.leit...@gmail.com; p...@nwl.cc > Subject: Re: [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode > > On 1/11/18 10:13 PM, Chris Mi wrote: > > Currently in tc batch mode, only one command is read from the batch > > file and sent to kernel to process. With this patchset, at most 128 > > commands can be accumulated before sending to kernel. > > > > We introduced a new function in patch 1 to support for sending > > multiple messages. In patch 2, we add this support for filter > > add/delete/change/replace and actions add/change/replace commands. > > > > But please note that kernel still processes the requests one by one. > > To process the requests in parallel in kernel is another effort. > > The time we're saving in this patchset is the user mode and kernel > > mode context switch. So this patchset works on top of the current kernel. > > > > Using the following script in kernel, we can generate 1,000,000 rules. > > tools/testing/selftests/tc-testing/tdc_batch.py > > > > Without this patchset, 'tc -b $file' exection time is: > > > > real 0m15.555s > > user 0m7.211s > > sys 0m8.284s > > > > With this patchset, 'tc -b $file' exection time is: > > > > real 0m12.360s > > user 0m6.082s > > sys 0m6.213s > > > > The insertion rate is improved more than 10%. > > LGTM. Applied to iproute2-next. Thank you, David. And thanks for your careful review that improves the code quality and design very much.
-Chris
