Hi Andy, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on next-20180206] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/r8169-switch-to-device-managed-functions-in-probe-part-2/20180207-053113 config: x86_64-randconfig-x001-201805 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/net//ethernet/realtek/r8169.c: In function 'rtl_init_one': >> drivers/net//ethernet/realtek/r8169.c:102:43: error: 'ioaddr' undeclared >> (first use in this function); did you mean 'in_addr'? #define RTL_W8(reg, val8) writeb ((val8), ioaddr + (reg)) ^ >> drivers/net//ethernet/realtek/r8169.c:8513:2: note: in expansion of macro >> 'RTL_W8' RTL_W8(Cfg9346, Cfg9346_Unlock); ^~~~~~ drivers/net//ethernet/realtek/r8169.c:102:43: note: each undeclared identifier is reported only once for each function it appears in #define RTL_W8(reg, val8) writeb ((val8), ioaddr + (reg)) ^ >> drivers/net//ethernet/realtek/r8169.c:8513:2: note: in expansion of macro >> 'RTL_W8' RTL_W8(Cfg9346, Cfg9346_Unlock); ^~~~~~ vim +102 drivers/net//ethernet/realtek/r8169.c ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 100 ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 101 /* write/read MMIO register */ ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 @102 #define RTL_W8(reg, val8) writeb ((val8), ioaddr + (reg)) ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 103 #define RTL_W16(reg, val16) writew ((val16), ioaddr + (reg)) ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 104 #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg)) ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 105 #define RTL_R8(reg) readb (ioaddr + (reg)) ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 106 #define RTL_R16(reg) readw (ioaddr + (reg)) 06f555f3 drivers/net/r8169.c Junchang Wang 2010-05-30 107 #define RTL_R32(reg) readl (ioaddr + (reg)) ^1da177e drivers/net/r8169.c Linus Torvalds 2005-04-16 108 :::::: The code at line 102 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torva...@ppc970.osdl.org> :::::: CC: Linus Torvalds <torva...@ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
