David Ahern wrote: > On 2/8/18 3:57 AM, Serhey Popovych wrote: >> Few minor changes to reduce diffs between ip and ipv6 tunnel code: >> >> 1) reduce intendation by one level when adding attributes in gre and >> gre6; reorder addattr*() calls to simplify diff >> >> 2) reorder local variables definition; change their type (e.g. for >> IFLA_LINK) to match ones returned by rta_getattr_*() >> >> 3) move "mode" parameter parsing in link_iptnl.c to the similar >> position as in link_ip6tnl.c >> >> 4) handle "tc" as shortcut for "tclass"/"tos" in link_iptnl.c >> >> 5) add whitespace where required >> >> Signed-off-by: Serhey Popovych <serhe.popov...@gmail.com> >> --- >> ip/link_gre.c | 91 >> +++++++++++++++++++++++++++--------------------------- >> ip/link_gre6.c | 83 ++++++++++++++++++++++++------------------------- >> ip/link_ip6tnl.c | 13 ++++---- >> ip/link_iptnl.c | 61 ++++++++++++++++++------------------ >> ip/link_vti.c | 2 +- >> ip/link_vti6.c | 2 +- >> 6 files changed, 127 insertions(+), 125 deletions(-) >> > > applied to iproute2-next. > > That is a large change for a single patch. Please send future cleanups > with grouped changes like you have done for other patches. gre/gr6 in > one patch, vti /vti6 in a second, etc. >
Accepted. Thank you!
signature.asc
Description: OpenPGP digital signature