On 02/13/2018 07:03 PM, Kirill Tkhai wrote:
> The patch is logically OK for me. The only thing I'm confused,
> I had to split it in 7 patches to review, otherwise the patch
> looks difficult to do. There is possible to extract:
> 1)Refactoring in __tipc_nl_compat_doit
> 2)Introduce __tipc_nl_bearer_disable()
> 3)Introduce __tipc_nl_bearer_enable()
> 4)Introduce __tipc_nl_bearer_set()
> 5)Introduce __tipc_nl_media_set()
> 6)Introduce __tipc_nl_net_set()
> 7)tipc: fix missing RTNL lock protection during setting link properties
> After that it becomes very easy to review the change you made in this patch.
> I attached them to message, and you may take the patches if there is one
> more version.
Thank you very much for your suggested patches! I have revised them
based on your idea and sent out v4 version. Please review them.