On Wed, Feb 21, 2018 at 05:40:29PM +0800, kbuild test robot wrote: > Hi Andrew, > > I love your patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Andrew-Lunn/net-dsa-mv88e6xxx-scratch-registers-and-external-MDIO-pins/20180221-150325 > config: i386-randconfig-i0-201807 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > drivers/net/dsa/mv88e6xxx/serdes.o: In function > `mv88e6xxx_g2_scratch_gpio_set_ext_smi': > >> drivers/net/dsa/mv88e6xxx/global2.h:478: multiple definition of > >> `mv88e6xxx_g2_scratch_gpio_set_ext_smi' > drivers/net/dsa/mv88e6xxx/chip.o:drivers/net/dsa/mv88e6xxx/global2.h:478: > first defined here > > vim +478 drivers/net/dsa/mv88e6xxx/global2.h > > 475 > 476 int mv88e6xxx_g2_scratch_gpio_set_ext_smi(struct mv88e6xxx_chip > *chip, > 477 bool external) > > 478 { > 479 return -EOPNOTSUPP; > 480 }
The stub function needs to be inline. I will fix up in v2. Andrew