> > +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter,
> > +                                   int vector_index)
> > +{
> > +   struct lan743x_vector *vector = &adapter->intr.vector_list
> > +                                   [vector_index];
> > +
> > +   devm_free_irq(&adapter->pci.pdev->dev, vector->irq, vector);
> Hu Bryan
> The point of devm_ is that you don't need to free resources you have
> allocated using devm_. The core will release them when the device is
> removed.

Hi Andrew,

When I remove the call devm_free_irq, I get a segmentation fault on close
in pci_disable_msix. Did I do something else wrong?

Also I'm allocating interrupt resources on interface up, and freeing resources
on interface down. So if there is an up, down, up sequence then the driver
will allocate resources twice. In order for devm to work properly, should I
move all resource allocation into the probe function?


Reply via email to