On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 23 Feb 2018 15:15:18 +1100 > > > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination. > > + * Requires NCSI_ATTR_IFINDEX and the preferred NCSI_ATTR_PACKAGE_ID and > > + * optionally the preferred NCSI_ATTR_CHANNEL_ID. If neither IDs are > > + * specified the setting is cleared. > > I think clearing the setting when the required attributes are missing > is dangerous behavior. > > It is ambiguous whether the user intended the setting to be cleared, > or was in error and forgot to supply the attribute due to a bug.
Fair point - I'll change this to be an error and add a separate command to clear the setting explicitly. In that vein is having NCSI_ATTR_CHANNEL_ID as an optional parameter ambiguous enough to justify a separate command as well? Regards, Sam
