On Wednesday 13 September 2006 22:02, Francois Romieu wrote: > [EMAIL PROTECTED] <[EMAIL PROTECTED]> : > [...] > > BACKDUR calculation is wrong at case 5. Also some cosmetic around > > smc911x_probe... > > If you are in a mood for cosmetic, feel free to turn some unsigned > long ioaddr into something more void __iomem *ioaddr and store it > in the private part of the device struct instead of dev->base_addr.
like struct smc911x_local *lp = netdev_priv(dev); void __iomem *ioaddr = lp->base_addr; ? > [...] > > @@ -1977,7 +1975,7 @@ > > case 4:/* 11520 Rx Data Fifo Size */ > > lp->afc_cfg=0x00783C9F;break; > > case 5:/* 10560 Rx Data Fifo Size */ > > - lp->afc_cfg=0x006E374F;break; > > + lp->afc_cfg=0x006E378F;break; > > Not your fault but the break statement is misplaced. One line below? Thanks for all of your comments. I will create a new set of patches... -- Bora SAHIN - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html