On 03/21/2018 11:58 AM, Richard Cochran wrote: > There are different ways of obtaining hardware time stamps on network > packets. The ingress and egress times can be measured in the MAC, in > the PHY, or by a device listening on the MII bus. Up until now, the > kernel has support for MAC and PHY time stamping, but not for other > MII bus devices. > > This patch moves the PHY time stamping interface into the generic > mdio device in order to support MII time stamping hardware. > > Signed-off-by: Richard Cochran <richardcoch...@gmail.com> > --- > drivers/net/phy/dp83640.c | 29 ++++++++++++++++++++--------- > drivers/net/phy/phy.c | 4 ++-- > include/linux/mdio.h | 23 +++++++++++++++++++++++ > include/linux/phy.h | 23 ----------------------- > net/core/ethtool.c | 4 ++-- > net/core/timestamping.c | 8 ++++---- > 6 files changed, 51 insertions(+), 40 deletions(-) > > diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c > index 654f42d00092..79aeb5eb471a 100644 > --- a/drivers/net/phy/dp83640.c > +++ b/drivers/net/phy/dp83640.c > @@ -215,6 +215,10 @@ static LIST_HEAD(phyter_clocks); > static DEFINE_MUTEX(phyter_clocks_lock); > > static void rx_timestamp_work(struct work_struct *work); > +static int dp83640_ts_info(struct mdio_device *m, struct ethtool_ts_info > *i); > +static int dp83640_hwtstamp(struct mdio_device *m, struct ifreq *i); > +static bool dp83640_rxtstamp(struct mdio_device *m, struct sk_buff *s, int > t); > +static void dp83640_txtstamp(struct mdio_device *m, struct sk_buff *s, int > t); > > /* extended register access functions */ > > @@ -1162,6 +1166,12 @@ static int dp83640_probe(struct phy_device *phydev) > list_add_tail(&dp83640->list, &clock->phylist); > > dp83640_clock_put(clock); > + > + phydev->mdio.ts_info = dp83640_ts_info; > + phydev->mdio.hwtstamp = dp83640_hwtstamp; > + phydev->mdio.rxtstamp = dp83640_rxtstamp; > + phydev->mdio.txtstamp = dp83640_txtstamp;
Why is this implemented a the mdio_device level and not at the mdio_driver level? This looks like the wrong level at which this is done. -- Florian
