On Mon, 26 Mar 2018 09:47:21 -0700 Alexei Starovoitov <a...@fb.com> wrote:
> I don't mind to _rename_ for_each_kernel_tracepoint() into > tracepoint_find_by_name(), but keeping exported function > just to be used by out-of-tree modules would be wrong message for > the kernel community in general. > With my patch the for_each_kernel_tracepoint() will be used by bpf side > and out-of-tree can trivially hack their callbacks to keep working. > imo that's a better approach then renaming it. Look, the tracepoint code was written by Mathieu for LTTng, and perf and ftrace were able to benefit because of it, as well as your bpf code. For this, we agreed to keep this function around for his use, as its the only thing he requires. Everyone has been fine with that. Not all out of tree code is evil. In fact, some out of tree modules help the kernel community. You ask why I care. Because PREEMPT_RT has been one of those out of tree modules that has helped the kernel community a lot. Have you noticed that there are "raw_spin_lock()" and "spin_lock()"? There's no difference between the two in the kernel. Why have them? Because they are used by PREEMPT_RT. Having that function for LTTng does not hurt us. And I will NACK removing it. -- Stevwe
