Hi Tal, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tal-Gilboa/net-broadcom-Fixup-broken-build-due-to-function-name-change/20180401-145037 config: x86_64-randconfig-x005-201813 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/ethernet/broadcom/bcmsysport.c: In function 'bcm_sysport_set_coalesce': >> drivers/net/ethernet/broadcom/bcmsysport.c:657:11: error: implicit >> declaration of function 'net_dim_get_def_rx_moderation'; did you mean >> 'net_dim_get_def_profile'? [-Werror=implicit-function-declaration] moder = net_dim_get_def_rx_moderation(priv->dim.dim.mode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net_dim_get_def_profile >> drivers/net/ethernet/broadcom/bcmsysport.c:657:9: error: incompatible types >> when assigning to type 'struct net_dim_cq_moder' from type 'int' moder = net_dim_get_def_rx_moderation(priv->dim.dim.mode); ^ drivers/net/ethernet/broadcom/bcmsysport.c: In function 'bcm_sysport_init_rx_coalesce': drivers/net/ethernet/broadcom/bcmsysport.c:1439:9: error: incompatible types when assigning to type 'struct net_dim_cq_moder' from type 'int' moder = net_dim_get_def_rx_moderation(dim->dim.mode); ^ cc1: some warnings being treated as errors vim +657 drivers/net/ethernet/broadcom/bcmsysport.c 624 625 static int bcm_sysport_set_coalesce(struct net_device *dev, 626 struct ethtool_coalesce *ec) 627 { 628 struct bcm_sysport_priv *priv = netdev_priv(dev); 629 struct net_dim_cq_moder moder; 630 u32 usecs, pkts; 631 unsigned int i; 632 633 /* Base system clock is 125Mhz, DMA timeout is this reference clock 634 * divided by 1024, which yield roughly 8.192 us, our maximum value has 635 * to fit in the RING_TIMEOUT_MASK (16 bits). 636 */ 637 if (ec->tx_max_coalesced_frames > RING_INTR_THRESH_MASK || 638 ec->tx_coalesce_usecs > (RING_TIMEOUT_MASK * 8) + 1 || 639 ec->rx_max_coalesced_frames > RDMA_INTR_THRESH_MASK || 640 ec->rx_coalesce_usecs > (RDMA_TIMEOUT_MASK * 8) + 1) 641 return -EINVAL; 642 643 if ((ec->tx_coalesce_usecs == 0 && ec->tx_max_coalesced_frames == 0) || 644 (ec->rx_coalesce_usecs == 0 && ec->rx_max_coalesced_frames == 0) || 645 ec->use_adaptive_tx_coalesce) 646 return -EINVAL; 647 648 for (i = 0; i < dev->num_tx_queues; i++) 649 bcm_sysport_set_tx_coalesce(&priv->tx_rings[i], ec); 650 651 priv->rx_coalesce_usecs = ec->rx_coalesce_usecs; 652 priv->rx_max_coalesced_frames = ec->rx_max_coalesced_frames; 653 usecs = priv->rx_coalesce_usecs; 654 pkts = priv->rx_max_coalesced_frames; 655 656 if (ec->use_adaptive_rx_coalesce && !priv->dim.use_dim) { > 657 moder = > net_dim_get_def_rx_moderation(priv->dim.dim.mode); 658 usecs = moder.usec; 659 pkts = moder.pkts; 660 } 661 662 priv->dim.use_dim = ec->use_adaptive_rx_coalesce; 663 664 /* Apply desired coalescing parameters */ 665 bcm_sysport_set_rx_coalesce(priv, usecs, pkts); 666 667 return 0; 668 } 669 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
