Hello, 

Since 90869ddfefeb net: aquantia: Implement pci shutdown callback
I get the below oops on reboot.  Without the callback everything works
as expected.

05:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz 
Ethernet Controller [AQtion] [1d6a:d107] (rev 02)
Fedora rawhide config - atlantic is a module.

....
[ 6278.083643] BUG: unable to handle kernel NULL pointer dereference at 
0000000000000058
[ 6278.091536] PGD 0 P4D 0 
[ 6278.094113] Oops: 0000 [#1] SMP NOPTI
[ 6278.097802] Modules linked in: nfsv3 nfs_acl nfs lockd grace fscache pppoe 
pppox ppp_synctty ppp_async ppp_generic slhc fuse xt_CHECKSUM iptable_mangle 
ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat 
nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack tun bridge stp llc 
devlink ebtable_filter ebtables ip6table_filter ip6_tables btrfs xor 
zstd_compress raid6_pq zstd_decompress xxhash sunrpc vfat fat edac_mce_amd 
snd_usb_audio kvm_amd ccp kvm raid1 snd_usbmidi_lib irqbypass mxm_wmi joydev 
ftdi_sio crct10dif_pclmul snd_rawmidi crc32_pclmul ghash_clmulni_intel 
snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel 
snd_hda_codec snd_hda_core snd_hwdep snd_seq snd_seq_device fam15h_power 
sp5100_tco k10temp snd_pcm i2c_piix4 snd_timer snd soundcore wmi shpchp
[ 6278.169417]  acpi_cpufreq binfmt_misc hid_logitech_hidpp hid_logitech_dj 
amdkfd amd_iommu_v2 amdgpu bnx2x chash i2c_algo_bit gpu_sched drm_kms_helper 
ttm nvme r8169 drm mii nvme_core mdio atlantic libcrc32c crc32c_intel i2c_dev 
[last unloaded: hwmon_vid]
[ 6278.192170] CPU: 6 PID: 1 Comm: systemd-shutdow Not tainted 
4.17.0-0.rc0.git5.2.fc29.x86_64 #1
[ 6278.200859] Hardware name: Gigabyte Technology Co., Ltd. To be filled by 
O.E.M./990FXA-UD3 R5, BIOS F2 04/01/2015
[ 6278.211208] RIP: 0010:aq_vec_stop+0x27/0x80 [atlantic]
[ 6278.216399] RSP: 0018:ffffb82983133d30 EFLAGS: 00010246
[ 6278.221704] RAX: 0000000000000000 RBX: ffff95dbd43c1800 RCX: 0000000000000000
[ 6278.228905] RDX: 00000000000001ff RSI: ffff95dbd43c1958 RDI: 0000000000000000
[ 6278.236117] RBP: ffff95dbd43c1958 R08: 0000000000000064 R09: 0000000000000000
[ 6278.243326] R10: 0000000000000001 R11: 0000000000000025 R12: 0000000000000000
[ 6278.250537] R13: 0000000000000006 R14: ffff95dbda58c000 R15: 0000000000000000
[ 6278.257749] FS:  00007f05685d3940(0000) GS:ffff95dbfed80000(0000) 
knlGS:0000000000000000
[ 6278.265913] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 6278.271727] CR2: 0000000000000058 CR3: 0000000819bc0000 CR4: 00000000000406e0
[ 6278.278940] Call Trace:
[ 6278.281420]  aq_nic_stop+0xfc/0x140 [atlantic]
[ 6278.285914]  aq_nic_shutdown+0x2c/0x40 [atlantic]
[ 6278.290671]  aq_pci_shutdown+0x15/0x40 [atlantic]
[ 6278.295446]  pci_device_shutdown+0x34/0x60
[ 6278.299614]  device_shutdown+0x14c/0x1f0
[ 6278.303609]  kernel_restart+0xe/0x30
[ 6278.307213]  SYSC_reboot+0x1cf/0x210
[ 6278.310821]  ? __alloc_fd+0x3d/0x140
[ 6278.314467]  ? do_writev+0x5c/0xf0
[ 6278.317925]  do_syscall_64+0x74/0x180
[ 6278.321619]  ? entry_SYSCALL_64_after_hwframe+0x3d/0xa2
[ 6278.326883] Code: 00 00 00 00 0f 1f 44 00 00 41 54 55 53 8b 47 18 48 89 fb 
85 c0 74 4f 48 8d af 58 01 00 00 45 31 e4 48 8b 03 48 89 ee 48 8b 7b 08 <48> 8b 
40 58 e8 10 89 92 e7 48 8b 03 48 8d 75 60 48 8b 7b 08 48 
[ 6278.345930] RIP: aq_vec_stop+0x27/0x80 [atlantic] RSP: ffffb82983133d30
[ 6278.352607] CR2: 0000000000000058
[ 6278.356010] ---[ end trace c32f052b515f1b02 ]---
[ 6278.363883] watchdog: watchdog0: watchdog did not stop!
[ 6278.369133] systemd-shutdow: 12 output lines suppressed due to ratelimiting
[ 6278.376180] Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x00000009
[ 6278.376180] 
[ 6278.385421] Kernel Offset: 0x26000000 from 0xffffffff81000000 (relocation 
range: 0xffffffff80000000-0xffffffffbfffffff)
[ 6278.396279] ---[ end Kernel panic - not syncing: Attempted to kill init! 
exitcode=0x00000009
[ 6278.396279]  ]---
.....

- Yanko

Reply via email to